search

romgrk / node-todoist

nodejs implementation of todoist sync API
21 stars 12 forks source link

No completed items? #23

Closed NeedsLoomis closed 2 years ago

NeedsLoomis commented 3 years ago

Heyo, great module!

Sync doesn't seem to grab completed items. Is there an option for this I'm missing?

NeedsLoomis commented 3 years ago

Update, if I mark an item checked through the API, its retrieved by sync(), but if I manually check it, it won't show up.

romgrk commented 2 years ago

It seems the API has a special route for that: https://developer.todoist.com/sync/v8/#get-all-completed-items

I'll close because it doesn't seem to be an issue in this module.

daviscodesbugs commented 2 years ago

It would be nice to include the ability to fetch completed items. @romgrk If I were to create a PR, would it be better as a parameter on .sync() (such as .sync(['completedItems'])), or a method on .items (such as .items.getCompleted())?

romgrk commented 2 years ago

@daviscodesbugs it depends, the package API mirrors closely the REST API, so it would depend on that.