search

romgrk / node-todoist

nodejs implementation of todoist sync API
21 stars 12 forks source link

Entry point for completed/get_all #30

Closed phbernard closed 2 years ago

phbernard commented 2 years ago

A new entry point completedItems for https://developer.todoist.com/sync/v8/#get-all-completed-items

romgrk commented 2 years ago

Looks good but the dist folder shouldn't be commited to the repo, it's only needed on NPM.

phbernard commented 2 years ago

Oh, my bad. I committed dist because it was easier for me to use the fork for my personal use, but it makes the PR quite messy. In additions, you've made a few legit comments about the code itself.

The update is small. You can drop this PR and simply pick the parts you want and adapt them yourself if you're comfortable with this approach.

phbernard commented 2 years ago

And by the way, thank you for making this project!

romgrk commented 2 years ago

Thanks but I'll close the PR if you don't wish to complete it. You or anyone else is welcome to re-open at anytime.