search

romgrk / termrk

Terminal for atom, using pty.js & term.js
MIT License
33 stars 7 forks source link

Fix for issue: #28 #36

Closed Reffyy closed 9 years ago

Reffyy commented 9 years ago

Only tested on Mac. Could someone give it a go on Windows/Linux?

Any comments - let me know and I'll jump straight on it.

romgrk commented 9 years ago

I've read the code, well done.

Normally, there shouldn't be any problem with this, so it should be updated as soon as I can test it on Windows/Linux. Unfortunately, I forgot my laptop charger, therefore I won't be able to test the code until next weekend. (See https://github.com/romgrk/termrk/issues/18 for details)

romgrk commented 9 years ago

Hello, the files have changed alot because I can only work offline. Now, I have all this pulled in my local copy, and I just finished merging everything. Should be in order, and all works fine. It is possible that your name doesn't appear in the contributors list because I merge this locally, but I will put a reference in there.

Oh, and by the way: thanks a LOT! I didn't had a clue on where to start to fix this issue.