romgrk / termrk

Terminal for atom, using pty.js & term.js
MIT License
33 stars 7 forks source link

Shell configuration is not respected #76

Closed pmcelhaney closed 8 years ago

pmcelhaney commented 8 years ago

On OS X 10.11.3, I can't get Termrk (0.2.3) to respect my setting for the shell. It always uses /bin/bash

My config.cson looks like this:

"*":
  Termrk:
    fontSize: "16px"
    restartShell: false
    shellCommand: "/usr/local/bin/bash"
  "atom-beautify":
    _analyticsUserId: "fe690c76-1820-491d-a901-8067940dd941"
  "atom-terminal":
    MacWinRunDirectly: true
    args: "-c /etc/launchd.conf"
    setWorkingDirectory: false
  "atom-terminal-panel": {}
  core:
    projectHome: "/Users/patrickmcelhaney/code"
  editor:
    fontSize: 13
    invisibles: {}
    preferredLineLength: 100
    showInvisibles: true
  "exception-reporting":
    userId: "56253752-48ef-bfea-869c-b3d462201b39"
  linter:
    showErrorPanel: false
  "linter-eslint": {}
  term3:
    autoRunCommand: "login -f `whoami`"
  welcome:
    showOnStartup: false

When I open a shell and type echo $SHELL I get /bin/bash rather than /url/local/bin/bash. I've tried other shells, such as /bin/zsh and got the same result.

pmcelhaney commented 8 years ago

PEBKAC

I tried debug the issue myself by starting atom with the --dev option and of course now it works. :)

romgrk commented 8 years ago

Great :)