search

romgrk / web-toolkit

A web UI framework based on GTK's Adwaita theme
https://romgrk.github.io/web-toolkit/docs
210 stars 7 forks source link

Optimize icons #12

Closed odama626 closed 3 years ago

odama626 commented 3 years ago

fixes https://github.com/romgrk/web-toolkit/issues/4

I created an optimized Icon element that can dynamically load icons by filename. I avoided replacing Icon for now because I noticed the icon names don't match the file names

this is built on pr:11

odama626 commented 3 years ago

and it seems I forgot to turn off prettier, sorry about the big diff.

this is the relevant change https://github.com/romgrk/web-toolkit/pull/12/files#diff-ecdb8a02bc7f073eb6e1b9186bd9d06555b9f298f6091211454c02d620b9804bR1121-R1146

romgrk commented 3 years ago

Ok, I haven't been able to see it working but I need this merged before I look at the split-package one so I'll merge, we can make it the default later. Great work btw, I had no idea this could be done.