romi / plant-3d-vision

Reconstruct a 3D digital twin of the plant from pictures (RGB images) and quantify its phyllotaxis.
https://docs.romi-project.eu/plant_imager/
GNU Lesser General Public License v3.0
5 stars 1 forks source link

Build docker from local sources #160

Closed naittaleb closed 3 years ago

naittaleb commented 3 years ago

close #157

These PR includes:

jlegrand62 commented 3 years ago

I am ok with the changes.

I see two changes on stuff I did to ease the work of "biologist", so I will let them argue if they still need it:

  1. you removed (again) the dev approach that speeds up the test of the docker build by creating a base image (useful for debug)
  2. you did not copy/transpose the 'git update' mechanism (run.sh) and we will have to rebuild the image from scratch every time (or hope that the docker build cache will save time for us)
jlegrand62 commented 3 years ago

By what mechanism the CI server has up-to-date local copies of each required repo and know the branches to use in the build ?!

naittaleb commented 3 years ago

By what mechanism the CI server has up-to-date local copies of each required repo and know the branches to use in the build ?!

For each pull_request, an action checkout is performed and the right branch is synchronized.

naittaleb commented 3 years ago

I am ok with the changes.

I see two changes on stuff I did to ease the work of "biologist", so I will let them argue if they still need it:

  1. you removed (again) the dev approach that speeds up the test of the docker build by creating a base image (useful for debug)
  2. you did not copy/transpose the 'git update' mechanism (run.sh) and we will have to rebuild the image from scratch every time (or hope that the docker build cache will save time for us)

As discussed during the meeting a cache mechanism could speed up the docker build and a nightly build will be performed every time new commits are pulled from dev