Closed naittaleb closed 3 years ago
I am ok with the changes.
I see two changes on stuff I did to ease the work of "biologist", so I will let them argue if they still need it:
dev
approach that speeds up the test of the docker build by creating a base image (useful for debug)run.sh
) and we will have to rebuild the image from scratch every time (or hope that the docker build cache will save time for us)By what mechanism the CI server has up-to-date local copies of each required repo and know the branches to use in the build ?!
By what mechanism the CI server has up-to-date local copies of each required repo and know the branches to use in the build ?!
For each pull_request, an action checkout is performed and the right branch is synchronized.
I am ok with the changes.
I see two changes on stuff I did to ease the work of "biologist", so I will let them argue if they still need it:
- you removed (again) the
dev
approach that speeds up the test of the docker build by creating a base image (useful for debug)- you did not copy/transpose the 'git update' mechanism (
run.sh
) and we will have to rebuild the image from scratch every time (or hope that the docker build cache will save time for us)
As discussed during the meeting a cache mechanism could speed up the docker build and a nightly build will be performed every time new commits are pulled from dev
close #157
These PR includes: