search

romibi / Scrap-Packed-Explorer

With this App it is planned to make it userfriendly to create a new or modify the contents of an existing .packed file for the Game Scrapland.
MIT License
3 stars 3 forks source link

Readme, Contributing and config and code cleanup #13

Closed Strongleong closed 2 years ago

Strongleong commented 2 years ago

Some stuff but no code

romibi commented 2 years ago

sorry i had to force push a stray commit out of your branch … make sure to reset your local branch to the remote

romibi commented 2 years ago

I now decided to change the bracket style to be on the same line as the control block codes (if else etc) … therefore all .cs files need to be updated … so i removed "Code unrelated" from the title … So @Strongleong feel free to also commit your method re-ordering you have already done somewhere to this branch!

Strongleong commented 2 years ago

So @Strongleong feel free to also commit your method re-ordering you have already done somewhere to this branch!

I thought it will be better to make separate ER from branch "cleaner-code" or something like that. But will commit it here

romibi commented 2 years ago

So @Strongleong feel free to also commit your method re-ordering you have already done somewhere to this branch!

I thought it will be better to make separate ER from branch "cleaner-code" or something like that. But will commit it here

I don't see a reason to split it up as it is all related …

Strongleong commented 2 years ago

I didn't changed code-style yet because we don't have any yet.

Strongleong commented 2 years ago

Did not touched any GUI code

Strongleong commented 2 years ago

Answers for partial review:

  • Why remove all var and use explicit datatypes?
  • UInt32 vs uint (see PackedMetaData.cs)

See comets

  • Any specific reason for all the changes similar to var variable = new ClassName(); → ClassName variable = new();? (I'm not against it…) See new comment in Contributing chapter "Brackets and indentation"

No specific reason. Choosed it in code-style settings by random. It's good that we don't need to change code everywhere by hand because "code cleaner" button do it for us :)

  • Why did empty.packed.bak shrink? Is there even a reason why it is (and was) tracked?

Actually, no idea. It don't even needs to be tracked

romibi commented 2 years ago

Went through all .editorconfig options and set them to the values of how I prefer them … Except the option for UInt32 vs uint … I'm still unsure about that … there are places where i prefer int or uint … and places where it has to be UInt32 …

I also formatted al .cs files to match these settings …

Still not finished reviewing yet 😕

romibi commented 2 years ago

For me the following Tests fail:

But at least for me

What is the current status of the unit tests for you?

If everything would have been green I'd have merged this now … But for debugging I currently don't have the time …

Idk if the issue is because of my changes or your changes … If you can check it out it would be nice … … otherwise maybe I'll have more time tomorrow.

Strongleong commented 2 years ago

All green. And I did not forgot to pull resent commits (but I could :sweat_smile: )

изображение