Backup functionality and its Tests needs refactoring and maybe has some bugs

romibi / Scrap-Packed-Explorer

With this App it is planned to make it userfriendly to create a new or modify the contents of an existing .packed file for the Game Scrapland.

MIT License

3 stars 3 forks source link

Open romibi opened 1 year ago

romibi commented 1 year ago

[ ] Option if old backup should be overwritten or not is completely ignored
[ ] TestBackup sometimes fails (on some systems) but often succeeds
- Only if TestData folder is in a Folder that is synced by synology drive client 😕
- Only sometimes
- needs more testing/debugging if issue is in our code or not
[ ] Backup/Restore logic should be extracted into its own class
- Maybe using callbacks in Scrap Packed File "DoOnBeforeSave", "DoOnSaveSuccess" and "DoOnSaveError"?

Strongleong commented 1 year ago

Maybe using callbacks in Scrap Packed File "DoOnBeforeSave", "DoOnSaveSuccess" and "DoOnSaveError"?

Ooo I like this. It our lib will be really good we could compile it to stand alone DLL with il2cpp and let anyone use it in their own projects