Closed karimbenbourenane closed 1 year ago
When installing using the recommended manual install, on Mac OS, the installer uses the apple logo glyph
What do you mean by this? What is "the installer" and how does it use the Apple logo?
My apologies for the incorrect language. I am referring to running p10k configure
.
How does p10k configure
use the Apple Logo?
Please see attached screenshot for how a homebrew
installed p10k looks when configure is run:
This question, just like the others before it, is there in order to detect font capabilities. You can recall that it asks about diamond, lock, etc.
I recall diamond, lock, etc, but installing this package as a custom oh-my-zsh plugin shows a different character than the Debian swirl. I cannot recall exactly what that character was, and I think your question is to point out that it isn't an apple logo. I am currently installing as an oh-my-zsh custom plugin to display the difference.
I think the newest version asks about an arrow but I don't remember if it can also ask about the debian logo in some circumstances. In any case, the question about the debian logo does not imply that you are running a debian OS or anything like that. It asks whether the logo renders correctly with your terminal and font.
FWIW, I've made the most recent changes in this area in order to support the new Nerd Font fonts.
Ok @romaktv a second apology for misremembering. It was not an apple logo in place of the Debian swirl. It was the up arrow. Here is what p10k configure
looks like when installed with the ohmyzsh route:
That is correct.
I understand that the specific character chosen is pretty inconsequential since this is a screen rendering diagnostic, but I thought I would bring it up in case there was some bug present that displays one icon for homebrew'd installs and a different icon for ohmyzsh installs. If there's no problem we can just close this issue. Thanks for looking into this.
There is no problem. The icon in master is different because I changed this part of the code recently to support the new release of Nerd Fonts. When I cut a new release of powerlevel10k, Homebrew will also display the new icon. It's a small change, so I'm not rushing with the release.
Excellent. Thanks for your attention @romkatv 👍
When installing using the recommended manual install, on Mac OS, the installer uses the apple logo glyph:
However, when installing with homebrew , it uses the latest release at https://github.com/romkatv/powerlevel10k/releases/tag/v1.17.0.
This release doesn't seem to be agnostic; it shows the Debian logo during the
p10k configure
step regardless of the OS it's running on.Would you be able to create releases that can auto-detect the target OS and display the correct OS logo so we do not have to rely on a non-release version of p10k by cloning the master branch of this repo?