romkobomko1993 / gyp

Automatically exported from code.google.com/p/gyp
0 stars 0 forks source link

post-filtering sources list should be accessible to actions #134

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
I need to run an action on all the sources of the target. Sources have ! and / 
filters applied on them, but there is no way to pass the filtered list to the 
action.

The variable _sources has the unfiltered list, while the _sources! and sources/ 
variables are not accessible (even if they were accessible, I would not want to 
emulate the calculation).

This blocks: https://bugs.webkit.org/show_bug.cgi?id=33048

Original issue reported on code.google.com by y...@chromium.org on 30 Dec 2009 at 11:52

GoogleCodeExporter commented 9 years ago
One possible backward compatible solution would be to expose 
"_sources_included" to 
variable expansions.

Original comment by y...@chromium.org on 30 Dec 2009 at 12:03

GoogleCodeExporter commented 9 years ago

Original comment by bradnelson@google.com on 25 Jan 2010 at 1:43

GoogleCodeExporter commented 9 years ago
Any update on this?  It's holding up a webkit patch that will make builds much 
faster.

Original comment by jor...@chromium.org on 17 Feb 2010 at 5:15

GoogleCodeExporter commented 9 years ago
/ and ! intentionally happen really late in the game.  It's not easy to get 
them to happen 
earlier (before variable expansion time).

Original comment by mark@chromium.org on 17 Feb 2010 at 6:38

GoogleCodeExporter commented 9 years ago
This issue blocks https://code.google.com/p/chromium/issues/detail?id=371513, 
fixing which requires us to specify an explicit list of inputs passed to a 
python script.

Original comment by apav...@chromium.org on 12 May 2014 at 11:10

GoogleCodeExporter commented 9 years ago
> / and ! intentionally happen really late in the game

Any insight into why this is intentional? In particular, why ordinary 
compilation targets can make use of the filtered "sources" while actions (in 
our case, it's a JavaScript compilation step executed as a python script) 
cannot?

Original comment by apav...@chromium.org on 12 May 2014 at 1:33