search

romkor / svelte-portal

Svelte component for rendering outside the DOM of parent component
https://svelte.dev/repl/407576d4fa984cfb97dcdd3da98e833e
MIT License
439 stars 21 forks source link

Conflicts in svelte resolve #176

Open DanielAlcaraz opened 1 year ago

DanielAlcaraz commented 1 year ago

Hi,

I upgraded my project dependencies and some new warnings appeared. This is the message: [vite-plugin-svelte] WARNING: The following packages use a svelte resolve configuration in package.json that has conflicting results and is going to cause problems future.

Here there is more info about the conflicts by the vite-plugin-svelte team: https://github.com/sveltejs/vite-plugin-svelte/blob/main/docs/faq.md#conflicts-in-svelte-resolve

development-vargamarcel commented 9 months ago

this might help (for maintaner): isue: https://github.com/ItalyPaleAle/svelte-spa-router/issues/310 fix: https://github.com/ItalyPaleAle/svelte-spa-router/pull/313

jonnitto commented 8 months ago

Should be solved with https://github.com/romkor/svelte-portal/commit/85fdeafa322f466752aa7d2adcb03d05c98310dc

development-vargamarcel commented 8 months ago

Thanks a ton

On Tue, Jan 16, 2024, 21:53 Jon Uhlmann @.***> wrote:

Should be solved with 85fdeaf https://github.com/romkor/svelte-portal/commit/85fdeafa322f466752aa7d2adcb03d05c98310dc

— Reply to this email directly, view it on GitHub https://github.com/romkor/svelte-portal/issues/176#issuecomment-1894495320, or unsubscribe https://github.com/notifications/unsubscribe-auth/AN5BQTAIVOURVEDURHE7XZLYO3SDFAVCNFSM6AAAAAAXKV5KRWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOJUGQ4TKMZSGA . You are receiving this because you commented.Message ID: @.***>

ctibo commented 7 months ago

I'm still getting the error with v2.2.1. Rolling back to v2.2.0 removes the issue.

Relevant package.json info from my setup :

"@sveltejs/kit": "^1.20.4",
"svelte": "^4.2.7",
"svelte-preprocess": "^5.1.0",
"svelte-portal": "^2.2.1"
"typescript": "^5.0.0",
"vite": "^4.5.0"

The issue: 

OUTPUT:
#12 28.71 2:27:47 PM [vite-plugin-svelte] WARNING: The following packages use a svelte resolve configuration in package.json that has conflicting results and is going to cause problems future.
#12 28.71
#12 28.71 svelte-portal@2.2.1
#12 28.71
#12 28.71 Please see https://github.com/sveltejs/vite-plugin-svelte/blob/main/docs/faq.md#conflicts-in-svelte-resolve for details.
[2024-Feb-28 14:27:48.181001]
mig-hub commented 6 months ago

Same, I get the error with 2.2.1 Indeed it does not warn when using 2.2.0 instead