rommapp / romm

A beautiful, powerful, self-hosted rom manager
https://romm.app
GNU Affero General Public License v3.0
2.38k stars 96 forks source link

[Bug] Covers only found when searching manually removing extensions #1167

Open Skeeve opened 2 months ago

Skeeve commented 2 months ago

RomM version

# docker images
REPOSITORY          TAG                 IMAGE ID            CREATED             SIZE
rommapp/romm        latest              ecf0a0def09b        3 days ago          289MB
mariadb             latest              92520f86618b        2 weeks ago         407MB

Describe the bug

RomM didn't find ANY. cover of any of my roms. For some, if I do a manual search and remove the extension (.gb in the example below), a cover ist found.

NOTE: I didn't upload my roms but copied them into library/roms There were all found but no Cover was found.

NOTE 2: I downloaded one of the roms and deleted it from the library. I noticed:

  1. The rom was removed from the list but not deleted from the filesystem
  2. Uploading the rom failed then
  3. When deleting the file manually uploading worked and the cover was found.

When selecting the cover and then "Rename", one can clearly see, that no real rename will take place.

To Reproduce Steps to reproduce the behavior:

  1. Have a file called "Amazing Tater.gb" with no cover
  2. Click on "Manual match"
  3. Search for "Amazing Tater.gb" -> Nothing is found
  4. Remove the extension and search again. "Amazing Tater" is found
  5. Rename and observe no change

Expected behavior

The cover should be found regardless of the extension.

Screenshots

image

Desktop (please complete the following information):

Smartphone (please complete the following information):

not used

Skeeve commented 2 months ago

If it's in, it didn't work. Example game: Boxxle.gb