rommapp / romm

A beautiful, powerful, self-hosted rom manager
https://romm.app
GNU Affero General Public License v3.0
1.85k stars 86 forks source link

[Bug] Uploads not working #1193

Open Crimson7806 opened 1 week ago

Crimson7806 commented 1 week ago

RomM version

3.5.1

Describe the bug

I cannot get uploads to work on non local connections, whether I am at work or using the guest network at home

To Reproduce

I made sure I was not connected locally to the host server in any way, I used my domain name I have setup via reverse proxy, and also tried my WAN IP with my port (yes I am port forwarded) and both pages loaded, but uploading doesn't work, it starts the upload, and cuts off seemingly randomly and says " All files skipped, nothing to upload." with an X mark on the file upload status. occasionally it says succeeded with a check mark, but the files do not appear to actually be on the server, and it still seemingly fails. nothing in the logs indicate any sort of status on uploads or downloads. I am not sure if the fact I am running on unraid changes anything. File formats do not seem to matter or affect it either, they all fail.

Expected behavior

Hopefully logs on Unraid would allow us to see a more in depth debugging on uploads and downloads, as there is no way to figure out if it is a client issue, server issue, or RomM issue. Myself and another user in the discord uploaded files to each other's servers, and no luck for either of us. Clearer debugging for uploads would be a big plus

Screenshots image

{BF8E6455-5D6C-403C-BCBE-2943B296C4C2}

Desktop (please complete the following information):

gantoine commented 1 week ago

can you post the container logs? either from the unraid UI or using the terminal with docker logs romm.

MightyDjinn commented 19 hours ago

This is likely an issue with the “proxy-body-size” on your reverse proxy. Check the developer console on your browser and see if any of those “x” contain a HTTP 413 response.

gantoine commented 18 hours ago

we use an internal nginx proxy as well, and we just merged a fix for proxy limits https://github.com/rommapp/romm/pull/1201

MightyDjinn commented 18 hours ago

I was speaking to the proxy that @Crimson7806 has sitting in front of the app. Sorry for the confusion!

gantoine commented 18 hours ago

ah no confusion at all! i was just mentioning that we have an internal proxy too that deals with proxy limits on uploads