search

rommapp / romm

A beautiful, powerful, self-hosted rom manager
https://romm.app
GNU Affero General Public License v3.0
2.37k stars 96 forks source link

misc: Initial addition of IGDB typehints #1265

Closed adamantike closed 3 weeks ago

adamantike commented 3 weeks ago

The short-term goal is to completely typehint the IGDB API responses. This first change adds the base structures and enums RomM currently uses.

The ExpandableField type will allow us to model the expansion mechanism the IGDB API provides, where a field can include either an ID, or the full nested structure.

github-actions[bot] commented 3 weeks ago

Test Results

88 tests  ±0   88 ✅ ±0   29s ⏱️ +3s  1 suites ±0    0 💤 ±0   1 files   ±0    0 ❌ ±0 

Results for commit 4bb5cb51. ± Comparison against base commit 373757e3.

:recycle: This comment has been updated with latest results.

zurdi15 commented 3 weeks ago

Great idea! This will help to make the API interaction much robust