rommapp / romm

A beautiful, powerful, self-hosted rom manager
https://romm.app
GNU Affero General Public License v3.0
2.33k stars 95 forks source link

[Bug] Unable to play games on supported platforms using platform version folders #1273

Open BrianAllred opened 2 weeks ago

BrianAllred commented 2 weeks ago

RomM version Latest Docker image - I believe that's 3.5.1

Describe the bug When using versioned platform folders for EmulatorJS supported platforms, the games in those folders are recognized by the scanner, but are unable to be played.

To Reproduce Steps to reproduce the behavior:

  1. Set up a standard gba platform folder and add at least 1 game.
  2. Notice the game is playable.
  3. Add a non-standard gba-romhacks platform folder.
  4. Configure the config.yml file like so:
    system:
    versions:
        gba-romhacks: gba
  5. Add at least 1 game to the gba-romhacks folder.
  6. Folder is recognized as the GBA platform and game is (or can be, depending on game/romhack) recognized by scanner
  7. Notice the game is unplayable.

Expected behavior Games in versioned platform folders should still be playable with EmulatorJS if the main platform is supported.

Screenshots Standard gba platform folder (notice the Play buttons): Screenshot_20241031_102356

Non-standard gba-romhacks platform folder (notice the lack of Play buttons even though the folder is recognized as GBA): Screenshot_20241031_102448

Desktop (please complete the following information):

Smartphone (please complete the following information):

adamantike commented 9 hours ago

For context, this is related to this code, where we define whether the platform is playable, by using the platform slug.