search

rommapp / romm

A beautiful, powerful, self-hosted rom manager
https://romm.app
GNU Affero General Public License v3.0
2.37k stars 96 forks source link

misc: Add MariaDB healthcheck recommendation to Docker Compose config #1278

Closed adamantike closed 1 week ago

adamantike commented 2 weeks ago

This commit adds a healthcheck configuration to the MariaDB service in the Docker Compose example configuration. The healthcheck script is a simple shell script that checks if the MariaDB server is ready to accept connections.

The application will wait for the MariaDB service to be healthy before starting the application service. This should solve issues where the database takes longer to start than the application, and logs some Something went horribly wrong with our database errors.

This change also stops recommending the linuxserver/mariadb image as an alternative. We have had users that change the image because of the first time run triggering those errors, but the linuxserver/mariadb image requires a different configuration that could be confusing for new users (e.g. volume mountpoint needs to be /config instead of /var/lib/mysql).

Moonraka commented 2 weeks ago

This worked when I tested it. I was having issues when using the linuxserver and now everything works as it should using the main mariadb server. (Mr Moon in discord)