[Bug] UI Settings "Group Roms" does not initially take effect

rommapp / romm

A beautiful, powerful, self-hosted rom manager

https://romm.app

GNU Affero General Public License v3.0

2.37k stars 96 forks source link

[Bug] UI Settings "Group Roms" does not initially take effect #1283

Closed MattTW closed 1 week ago

MattTW commented 1 week ago

RomM version 3.5.1

Describe the bug On a fresh install, the "Group Roms" setting displays as True, however roms are not grouped unless the setting is re-toggled.

Additional context I can see in the code that the logic to read the setting is not consistent with the other UI Settings (i.e. default to true if the returned value is null/never been set). I can submit a quick pull request to make this consistent.

zurdi15 commented 1 week ago

Yeah this have been there for a while now, a PR would be much appreciated!