rommapp / romm

A beautiful, powerful, self-hosted rom manager
https://romm.app
GNU Affero General Public License v3.0
1.83k stars 84 forks source link

[Bug] Romm serving ~500mb webpage downloads instead of ROM files #581

Closed Casuallynoted closed 6 months ago

Casuallynoted commented 8 months ago

RomM version dev-latest

Describe the bug Lately, when I've gone to download files from my Romm instance, it'll spit out a between 500-700ish mb file containing this:

<!DOCTYPE html>

RomM

It has the name and extension of what I'm trying to download but definitely isn't it.

So far, I've determined that it seems to happen sometime after the app is started (if I restart it does seem to go away for a while if I've cleared my browser cache/cookies) and doesn't seem to be specific to any browser/OS. I've also double checked that Cloudflare isn't interfering with this by disabling all CF caching/proxying features while testing. It also doesn't seem to have anything to do with the download being a single or multi file rom.

Additional context Previously discussed in the Discord thread here: https://discord.com/channels/1138838206532554853/1193393278842839142

gantoine commented 8 months ago

This is likely also a symptom of the PWA thing you mentioned in the other issue. I think relaxing how hard romm caches assets should help things quite a bit.

gdiazbanuelos commented 8 months ago

Are you using Firefox? I had the same issue and I tried Chrome and Edge and it downloaded fine. I am not sure if this is something that can be fixed or if it is just a Firefox limitation on how it handles downloads.

Casuallynoted commented 8 months ago

I am, but I’ve had the same issue on chrome as well, and I can say Romm used to work perfectly with Firefox. The issue also happens with Safari.

gantoine commented 6 months ago

Closing in favor of #630