rommapp / romm

A beautiful, powerful, self-hosted rom manager
https://romm.app
GNU Affero General Public License v3.0
2.32k stars 95 forks source link

Question: How go deal with version of ROM ? #682

Closed znoxx closed 8 months ago

znoxx commented 8 months ago

My config file part:

system:
  platforms:
    GENESIS: 'genesis-slash-megadrive' # In this example if you have a 'gc' folder, RomM will treat it like the 'ngc' folder
    NES: 'nes' # In this example if you have a 'psx' folder, RomM will treat it like the 'ps' folder
    SNES: 'snes'
  versions:
    mame: 'arcade'
    CPS1: 'arcade'
    CPS2: 'arcade'
    CPS3: 'arcade'
    neogeotest: 'neogeomvs'

In MAME folder i have 2 files: term2.zip term2la.zip

Those files are treated as Terminator 2 Arcade, which is correct. But in description I see combobox "Versions", with 2 entries (absolutely correct). The problem is -- those values are empty in combobox

image

How can I edit those entries, assigning here values e.g. rev LA4 08/03/92 rev LA2 12/09/91

Thanks in advance.

gantoine commented 8 months ago

Yeah that's a bug, we didn't consider this in our code. I'll backlog it and fix it in a future release.

Update: this will be fixed in the 3.1 release.

znoxx commented 8 months ago

Thanks a lot for fast reaction! Your product is fantastic, especially for handheld emulator owners. Will use it on regular basis.

gantoine commented 8 months ago

Fixed in the latest release

znoxx commented 8 months ago

Will give a try in couple of days. Can you please point to right docker image ?

gantoine commented 8 months ago

Sure thing, you can pin romm to 3.0.1, the fix is in that version

znoxx commented 8 months ago

Hi there. Not sure it worked.

Here is my folder: image

Here is a part of my config:

# Associate different platform names to your current file system platform names
system:
  platforms:
    GENESIS: 'genesis-slash-megadrive' # In this example if you have a 'gc' folder, RomM will treat it like the 'ngc' folder
    NES: 'nes' # In this example if you have a 'psx' folder, RomM will treat it like the 'ps' folder
    SNES: 'snes'
    psxtest: 'ps'
    dctest: 'dc'
    neogeotest: 'neogeomvs'
    pcengine: 'turbografx16--1'
  versions:
    mame: 'arcade'
    CPS1: 'arcade'
    CPS2: 'arcade'
    CPS3: 'arcade'

docker-compose part:

version: '3'
services:
  romm:
    image: zurdi15/romm:3.0.1
    container_name: romm
    environment:
      - ROMM_DB_DRIVER=mariadb # mariadb 
      - ROMM_HOST=https://localhost:3000 # [Optional] your host ip or domain name (including http(s)://, subdomain and port if needed). Being used only for webRcade feed for now.
      - ROMM_AUTH_SECRET_KEY=328b159c2fb10bd285d9cd938153d5f2de5bdef6e8e7836194d59c9bc0d8b014
      - ROMM_AUTH_USERNAME=admin
      - ROMM_AUTH_PASSWORD=admin
      - DISABLE_CSRF_PROTECTION=true
      - DB_HOST=romm_db
      - DB_PORT=3306
      - DB_USER=romm-user
      - DB_NAME=romm # Should match the MYSQL_DATABASE value in the mariadb container
      - DB_PASSWD=rommsql
      - IGDB_CLIENT_ID=xxxxxx  # Fill in the client ID from the previous step
      - IGDB_CLIENT_SECRET=xxxx  # Fill in the client secret from the previous step
      - ENABLE_RESCAN_ON_FILESYSTEM_CHANGE=true 
      - ROMM_HOST=https://localhost:3000 
      - ENABLE_SCHEDULED_UPDATE_MAME_XML=true
      - SCHEDULED_UPDATE_MAME_XML_CRON=0 5 * * *
    volumes:
      - 'library:/romm/library/roms'
      - './resources:/romm/resources'
      - './assets:/romm/assets'
      - './logs:/romm/logs'
      - './config:/romm/config'
      - './romm_redis_data:/redis-data'

After scan, both term2.zip and term2la2.zip were attached to same title (Terminator 2). I changed game title to Terminator 2 Arcade (which is correct)

And here is the result:

image

Combobox has 2 emtpy values, but they successfully switch the title

term2.zip: image

term2la.zip image

Honestly, I don't see any changes introduced. Also i cannot see any commit for this issue.

gantoine commented 8 months ago

@znoxx I apologize for the confusion, the fix was not released 3.0.1, but will be released in 3.1.