[Bug] Compressed downloads are not actual zip files

[ameturpoet]

RomM version 3.0.1

Describe the bug When downloading a rom from the webUI, RomM will attempt to compress the rom file for the download. However, this file is actually just the rom file with the file extension renamed to .zip, and thus will not successfully decompress. It would be nice to have an option to bypass compression entirely for single-file roms.

To Reproduce Steps to reproduce the behavior:

1. Go to game library
2. Click on download button for any given game
3. Attempt to extract the downloaded zip file
4. When the extract fails, rename the zip file to the original rom file extension and test it in an emulator

Expected behavior Downloaded single-file roms will not be compressed to a zip, or downloaded zips will actually be compressed archive files instead of renamed files.

Desktop (please complete the following information):

• OS: macOS 14.3.1
• Browser: Safari 17.3.1

Additional context Running via docker image in Unraid.

[gantoine]

So I tested this both my dev and real instances of romm, and in both cases with .gba games, the files are downloading as .gba and not fake zips. Could you try to download it again, but this time before you download, open the developer tools in your browser, navigate to the "Network" tab, hit download (you should see a new line appear), then screenshot (or copy since it'll be all text) and paste the "Headers", "Request" and "Response" tabs? Should look something like this:

[ameturpoet]

I tried doing so in Safari, but nothing new appeared in the Network tab of the developer panel when downloading a game. I tested the downloads out on other browsers just out of curiosity, and I think this might be a Safari-specific issue? Downloading files which were zips in Safari are just normal roms in Firefox and Chrome.

[gantoine]

This should be fixed in the next release (3.2.0). If you still see it after the upgrade, please ping me here and I'll re-open the issue.