v3.0.2 release notes issue

rommapp / romm

A beautiful, powerful, self-hosted rom manager

https://romm.app

GNU Affero General Public License v3.0

1.77k stars 80 forks source link

v3.0.2 release notes issue #755

Closed lnlyssg closed 5 months ago

lnlyssg commented 5 months ago

A minor problem but the release notes for v3.0.2 say "Updated docker-compose.example.yml file to match new dockerhub rommapp organization" but the linked file is the v3.0.1 version so still contains zurdi15/romm

gantoine commented 5 months ago

Fixed, thank you! You should use 3.0.3 however since 3.0.2 has a critical bug.

lnlyssg commented 5 months ago

Yup it was when I was updating again to 3.0.3 that I spotted the issue. Will the example docker-compose file be updated to include the user:uid:gid entry or is this just a temporary measure?

gantoine commented 5 months ago

Will the example docker-compose file be updated to include the user:uid:gid entry or is this just a temporary measure?

So uh turns out that still doesn't work in 3.0.3. I've been trying to getting working all evening but with no luck. There's a catch-22 with folder permissions on build vs user ID on run. If you're familiar with this stuff I could really use the help!

lnlyssg commented 5 months ago

It seems to be working Ok for me, I was getting permissions errors on the log file e.g. PermissionError: [Errno 13] Permission denied: '/romm/logs/20240325_170108.log' And it just kept looping so I then specified the user entry like the below dummy example and now everything looks to be working OK:

services:
  romm:
    image: rommapp/romm:3.0.3
    container_name: romm
    restart: unless-stopped
    user: 123:456
    environment:
      - DB_HOST=romm-db
      ...

gantoine commented 5 months ago

Yeah that's the issue, passing in user: with any real user ID that's not root will fail. I've been chatting with some other contributors this morning and we might have a plan to allow for this, though it'll take some time to migrate.

lnlyssg commented 5 months ago

Strange.... it's working fine for me with a non-root user, this was prior to the upgrade:

and then after I got it working at 17:05 today: