rommapp / romm

A beautiful, powerful, self-hosted rom manager
https://romm.app
GNU Affero General Public License v3.0
1.77k stars 80 forks source link

Extended/ID search not working #866

Closed Dreadlocke12 closed 3 months ago

Dreadlocke12 commented 3 months ago

RomM version 3.1.0

Describe the bug I have the plattform pico-8 created for pico-8 games but when i search for artwork over igdb I can not find it. I know the game exists in the database but is not related to a plattform. The URL is https://www.igdb.com/games/netty so basically this is part of the IGDB games folder. Searching using the ID is not working as well. The same behaviour goes for other platforms which are also listed in IGDB. It seems if it is not related directly to the platform in IGDB finding it is not possible.

To Reproduce Steps to reproduce the behavior:

  1. Manual Search
  2. Search by name or search by ID
  3. Error sign without text appears

Expected behavior No suggestions are provided

Screenshots Screenshot 2024-05-22 at 10 04 23 Screenshot 2024-05-22 at 10 04 19 Screenshot 2024-05-22 at 10 04 04

Desktop (please complete the following information):

Smartphone (please complete the following information):

Tom-Welch commented 3 months ago

I've also been trying to search by ID as I know the game exists on IGDB. Here's a couple of things i've found whilst digging.

My log file is showing a dictionary key error. /backend/endpoints/search.py Line 81.

Excuse my limited experience, but it appears as if even with the Moby Games provider disabled, the moby_matched_roms variable is still being looped over to merge the dicts which is throwing the key error as it's empty.

gantoine commented 3 months ago

Duplicate of #838, fix is here 👉🏼 https://github.com/rommapp/romm/pull/863