rommapp / romm

A beautiful, powerful, self-hosted rom manager
https://romm.app
GNU Affero General Public License v3.0
2.03k stars 88 forks source link

[Bug] Cover Art wont Update on unmatched game #920

Closed from-nibly closed 4 months ago

from-nibly commented 4 months ago

RomM version 3.2.0

Describe the bug I upgraded from 3.1.0-rc.2 After that all of the images for roms not matched with moby games don't have cover art anymore. Also editing roms by reuploading the cover art doesn't do anything. Checking the logs and the browser network tab reveals 0 errors or helpful logs.

To Reproduce Steps to reproduce the behavior:

  1. upload rom hack or other unmatchable rom
  2. (might not be required) upgrade a database from 3.1.0-rc.2 to 3.2.0
  3. navigate to the rom
  4. click edit
  5. Upload new image (jpeg in my case)
  6. click save.
  7. Nothing happens, image is still missing

Expected behavior not lose my cover art, and also be able to upload new cover art. or at least have some logs showing what happened

Screenshots image

Desktop (please complete the following information):

from-nibly commented 4 months ago

Additional Context. Here's the payload that I get back for this particular rom

{
  "id": 817,
  "igdb_id": null,
  "sgdb_id": null,
  "moby_id": null,
  "platform_id": 111,
  "platform_slug": "gba",
  "platform_name": "Game Boy Advance",
  "file_name": "Pokemon Altered Emerald (v4.2).gba",
  "file_name_no_tags": "Pokemon Altered Emerald",
  "file_name_no_ext": "Pokemon Altered Emerald (v4.2)",
  "file_extension": "gba",
  "file_path": "roms/gba",
  "file_size_bytes": 16777216,
  "name": "Pokemon Altered Emerald",
  "slug": null,
  "summary": "",
  "first_release_date": 0,
  "alternative_names": [],
  "genres": [],
  "franchises": [],
  "collections": [],
  "companies": [],
  "game_modes": [],
  "igdb_metadata": {},
  "moby_metadata": {},
  "path_cover_s": "gba/Pokemon%20Altered%20Emerald/cover/small.jpeg",
  "path_cover_l": "gba/Pokemon%20Altered%20Emerald/cover/big.jpeg",
  "has_cover": true,
  "url_cover": "",
  "revision": "",
  "regions": [],
  "languages": [],
  "tags": [
    "v4.2"
  ],
  "multi": false,
  "files": [],
  "full_path": "roms/gba/Pokemon Altered Emerald (v4.2).gba",
  "merged_screenshots": [],
  "sibling_roms": [],
  "user_saves": [],
  "user_states": [],
  "user_screenshots": [],
  "user_notes": [],
  "sort_comparator": "pokemon altered emerald"
}
zurdi15 commented 4 months ago

Hi! This is a known issue of how RomM renders the cover art. It's already fixed and will be shipped in the next version! You don't even will need to update the covers, they will appear automatically.

from-nibly commented 4 months ago

Awesome. I was just going to jump in to say that I think it was a frontend issue because curling the url built by this guy https://github.com/rommapp/romm/blob/3.2.0/frontend/src/components/Game/Card/Cover.vue#L98-L114 returned the image just fine. And looking through the network tab it seems like it's just not even requesting the image in the first place.

Will keep an eye on the releases, thanks!