rompetomp / inertia-bundle

Inertia.js server-side adapter for Symfony
MIT License
153 stars 41 forks source link

Allow PHP 8, move tests to GitHub Actions #25

Closed aleksblendwerk closed 4 years ago

aleksblendwerk commented 4 years ago

Short summary:

The badge in README.md should display right when this is merged - but from what I can see it will always display the status for the master branch - not sure if this was any different using Travis CI. There is a way to manually change the branch the badge refers to for long-running branches though.

I have also made a quick test using this version within pingcrm-symfony on PHP 8.0 and all seems fine.

aleksblendwerk commented 4 years ago

Hmm. I am not sure if the proposed GitHub Actions workflow was supposed to show up here as a check already. Might only be activated after you agreed on merging the PR. It is set to run on every push and PR.

rompetomp commented 4 years ago

Thanks Aleks, looking good, like always! I'll merge the PR, and we'll see if it will run the Github action :D

aleksblendwerk commented 4 years ago

Looking good, nice! 😇

Also: you are the fastest PR merger and new release builder ever! Thanks! 🚀