search

rompetomp / inertia-bundle

Inertia.js server-side adapter for Symfony
MIT License
151 stars 36 forks source link

Inertia version is null #26

Open JakubRobotka opened 3 years ago

JakubRobotka commented 3 years ago

Hello, thanks for this nice bundle.

I have a little problem with settings version for Inertia. When i set in my subscriber version, i get always refresh. for example if i set this as my version $this->inertia->version('123')

i would except to not get refresh on every request. After a little debugging i found, that in InertiaListener.php theres a condition for checking versions. (i am not be dev) After dump, i can see version is null.

var_dump($request->headers->get('X-Inertia-Version')); var_dump($this->inertia->getVersion()); Results in: /srv/app/vendor/rompetomp/inertia-bundle/EventListener/InertiaListener.php:38:string '123' (length=3) /srv/app/vendor/rompetomp/inertia-bundle/EventListener/InertiaListener.php:39:null

Tofandel commented 2 years ago

This bundle is a bit outdated compared to the Laravel one, it's missing a few things, mainly LazyProp and automated version control using manifest.json, I published a v3 under composer remove rompetomp/inertia-bundle && composer install tofandel/inertia-bundle which is now up to date with the features of the laravel package