When rendering certain data I ended up getting an ArgumentCountError, and in this specific case it was because PHP's system global function was trying to be called with 0 arguments. This seemed odd because we don't call system anywhere in our code.
It seems that this is due to the is_callable check that was added in #42. In our case, we had a value that was System for an item in an array (not a parent level prop, but an array of data that we were passing to Inertia).
The previous behavior of checking if the prop was a Closure didn't have this issue. I suspect anyone that has basic string props that happen to match a global PHP function name will also run into this issue of inertia trying to execute PHP functions when the prop itself was just a simple string.
jaydiablo
commented
1 year ago
Since #42 landed I noticed a bug in this bundle.
When rendering certain data I ended up getting an
ArgumentCountError, and in this specific case it was because PHP'ssystemglobal function was trying to be called with 0 arguments. This seemed odd because we don't callsystemanywhere in our code.It seems that this is due to the
is_callablecheck that was added in #42. In our case, we had a value that wasSystemfor an item in an array (not a parent level prop, but an array of data that we were passing to Inertia).is_callablewill accept a string as the first parameter, and if that string is a global function name (whichsystemis, https://www.php.net/system)is_callablewill returntrueand then try to execute that function in thecall_user_functhat follows (https://github.com/rompetomp/inertia-bundle/blob/master/Service/Inertia.php#L160) which is probably not the intent here.https://3v4l.org/I9QKY
The previous behavior of checking if the prop was a
Closuredidn't have this issue. I suspect anyone that has basic string props that happen to match a global PHP function name will also run into this issue of inertia trying to execute PHP functions when the prop itself was just a simple string.