romuel / connectbot

Automatically exported from code.google.com/p/connectbot
Apache License 2.0
0 stars 0 forks source link

Wishlist feature + patch: url scanning for multi-line urls #190

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
What steps will reproduce the problem?
1. Have a URL that spans more than one line
2. Use scan urls from the menu to search for it
3. Only the first part (on the first line) will be found

What is the expected output? What do you see instead?
I would like the full URL to be matched, instead of only the first part.

What version of the product are you using (you can see this by using Menu
-> About in the Host List)?
SVN revision 404

Please provide any additional information below.
I have attached a patch against
src/org/connectbot/service/TerminalBridge.java to fix the issue. If still a
valid url, it will also match URL's splitted by a '+' character at the
right edge of the terminal (like Mutt does). Possible drawback: if a URL
actually end at the right edge of the terminal, and there is some text on
the next line, only a concatenation will be found.

Original issue reported on code.google.com by pieter.w...@gmail.com on 28 Aug 2009 at 3:44

Attachments:

GoogleCodeExporter commented 8 years ago
The reason I didn't want to do this initially is it's easy to make mistakes as 
you
pointed out.

Perhaps a better solution would be to have a plus sign on the right or 
something that
grabs more text from the next line. Maybe even a way to edit the URL before it 
is opened.

Original comment by kenny@the-b.org on 2 Sep 2009 at 11:58

GoogleCodeExporter commented 8 years ago
I would advocate including this feature in a simple way akin to the suggested 
patch. Would it be difficult to just 
include both, the truncated URL as well as the best-guess concatentation if 
there appears to be more? The URL 
scan is already a guess. This would be a really nice feature to have.

Original comment by gwillen@gmail.com on 21 Oct 2009 at 6:51

GoogleCodeExporter commented 8 years ago
I think this mostly works. URL regex probably needs to change.

Original comment by kenny@the-b.org on 12 Feb 2010 at 4:50