Relax Poison dependency

romul / newrelic.ex

NewRelic agent for Elixir

MIT License

64 stars 19 forks source link

Relax Poison dependency #10

Closed Arkham closed 5 years ago

Arkham commented 6 years ago

Hi there,

just realized you can't use this plugin when you're using phoenix 1.3. I relaxed the dependency just as it is done in the phoenix mix.exs (https://github.com/phoenixframework/phoenix/blob/master/mix.exs)

romul commented 6 years ago

Hello, @Arkham! This is your first Pull Request that will be reviewed by Ebert, an automatic Code Review service. It will leave comments on this diff with potential issues and style violations found in the code as you push new commits. You can also see all the issues found on this Pull Request on its review page. Please check our documentation for more information.

romul commented 6 years ago

Ebert has finished reviewing this Pull Request and has found:

1 possible new issue (including those that may have been commented here).

You can see more details about this review at https://ebertapp.io/github/romul/newrelic.ex/pulls/10.

Catharz commented 6 years ago

👍 for this change, I had to downgrade Poison in my app to get this to install. @romul can we get this progressed? Looking at the diff, it seems the issue Ebert raised was there before @Arkham's change.

romul commented 5 years ago

Sorry for the delay, merged now.