search

romul / newrelic.ex

NewRelic agent for Elixir
MIT License
64 stars 19 forks source link

Use system DNS hostname to determine current host name. #12

Closed ohmycto closed 6 years ago

ohmycto commented 6 years ago

This makes NewRelic agent hostname value and OS hostname command output identical and more precise.

It also avoids issues with NewRelic licenses when different agents send data from the same host, but Ruby-agents indicate it as full hostname (e.g. vs01.example.net) and Elixir agents as short hostname (e.g. vs01). NewRelic considers these as different app hosts in term of their license.

romul commented 6 years ago

Hello, @secoint! This is your first Pull Request that will be reviewed by Ebert, an automatic Code Review service. It will leave comments on this diff with potential issues and style violations found in the code as you push new commits. You can also see all the issues found on this Pull Request on its review page. Please check our documentation for more information.

romul commented 6 years ago

Ebert has finished reviewing this Pull Request and has found:

You can see more details about this review at https://ebertapp.io/github/romul/newrelic.ex/pulls/12.