search

romulomachado / ember-cli-string-helpers

Set of the String helpers extracted from DockYard's ember-composable-helpers.
Other
73 stars 30 forks source link

Project build contains all "app exports" from ember-cli-string-helpers #294

Closed bertdeblock closed 3 years ago

bertdeblock commented 3 years ago

Version

v5.0.0

Test Case

Steps to reproduce

Expected Behavior

my-app.js only includes the lowercase app export.

Actual Behavior

my-app.js includes the app exports of all string helpers.

By "app export" I mean, the re-exports defined in this addon's app folder. These can be filtered out as well using the treeForApp hook.

Ember Composable Helpers example.

But Why?

One of our projects uses an internal addon which ships its own html-safe helper. Even though we've configured ember-cli-string-helpers to not include the html-safe helper, there's a conflict between the two because the html-safe app export of ember-cli-string-helpers is still included in the final build.

Of course, we've removed our own custom helper, because there's no point in reinventing the wheel, but I just wanted to share this issue (even though it's and edge case).

It would also save some bytes.

romulomachado commented 3 years ago

Closed with #315