search

romulomachado / ember-cli-string-helpers

Set of the String helpers extracted from DockYard's ember-composable-helpers.
Other
73 stars 30 forks source link

build: manage dependencies #337

Closed ndekeister-us closed 1 year ago

ndekeister-us commented 3 years ago

Changes proposed in this pull request

build: rename ember-cli-uglify to ember-cli-terser (https://github.com/romulomachado/ember-cli-string-helpers/pull/337/commits/c798fda60bd4d34be9ff4284c914a088aebb7fc6)

ember-cli-uglify have been renamed to ember-cli-terser, also bump it from 3.0.0 to 4.0.2, no changes seems needed according to the changelog

Note that this change should've been made automatically via en ember-cli update, so it seems probable that some other changes was not applied via a previous ember-cli update

build: remove ember-cli-htmlbars-inline-precompile devDependencies (https://github.com/romulomachado/ember-cli-string-helpers/pull/337/commits/cabacfa9e0a96b664621a200c50a090c5b894a25)

It was not needed anymore as we use ember-cli-htmlbars in this repo, see https://github.com/ember-cli/ember-cli-htmlbars-inline-precompile#deprecated

ndekeister-us commented 2 years ago

ping @romulomachado , this is not important stuff at all, but may i ask for a review on this one?