search

ronaldburns / PlaceholderAPI

An advanced placeholder hub for the Sponge API
https://ore.spongepowered.org/rojo8399/PlaceholderAPI
MIT License
16 stars 15 forks source link

Plugin breaks when non default config/plugin folder are used #43

Closed phit closed 6 years ago

phit commented 6 years ago

SpongeAPI version: 5/7 PlaceholderAPI version: PlaceholderAPI-4.3.jar Plugins installed: doesn't matter, but tested with VirtualChest

Error log: https://gist.github.com/phit/3183779fc09b5fef9943abcdf6e1dd06

Plugin completely breaks down when you have non default config and plugin folder paths set in your Sponge global.conf In this case I had it set to:

        config-dir="${CANONICAL_GAME_DIR}/plugins/config"
        plugins-dir="${CANONICAL_GAME_DIR}/plugins"

Workaround is manually putting configs generated on another server in the usual config/ folder. Then it loads fine..

Wundero commented 6 years ago

I will have a fix for this in the next version. I don't know what the root issue of this is that is making the config null but I have a workaround that should fix this issue for the most part.

Wundero commented 6 years ago

@rojo8399 Do you know why the config would be null? I can't seem to figure out what's going wrong here. Our dependencies are not attached to a file location but injected, so there shouldn't be problems like this right?

ziceptor commented 6 years ago

my settings

config-dir="${CANONICAL_GAME_DIR}/config" plugins-dir="${CANONICAL_MODS_DIR}/plugins"

Wundero commented 6 years ago

The issue isn't tied to the directories necessarily; it seems to be an issue within the file loading that the nodes are not loaded. I am keeping this issue open because it was first but it will be fixed in 4.4.

Wundero commented 6 years ago

Should be fixed now, but I have no good way to test this so please check.