search

ronaldleonj / dashclock

Automatically exported from code.google.com/p/dashclock
0 stars 0 forks source link

Weather extension displaying "<Location>," #10

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
What is the expected output? What do you see instead?

The appended text or no comma.

What version of the product are you using?

Play Store current

Which device and Android version are you experiencing this issue on?

Nexus 4, CM10.1 latest nightly at time of posting.

Original issue reported on code.google.com by ldjugg...@gmail.com on 12 Feb 2013 at 10:15

GoogleCodeExporter commented 9 years ago 
Oh, very interesting. Can you take a screenshot and post it here? Might be a 
parser bug.

Original comment by roman.nurik on 12 Feb 2013 at 12:02

GoogleCodeExporter commented 9 years ago 
Here's a screenshot of the problem. I'm also on N4 using CM10.1 nightly (latest)

Original comment by kris.nielsen1 on 12 Feb 2013 at 12:09

Attachments:

GoogleCodeExporter commented 9 years ago 
Alright, thanks!

Original comment by roman.nurik on 12 Feb 2013 at 12:11

GoogleCodeExporter commented 9 years ago 
@kris I was just about to add mine, cheers :)

Original comment by ldjugg...@gmail.com on 12 Feb 2013 at 12:11

GoogleCodeExporter commented 9 years ago 
https://code.google.com/p/dashclock/source/browse/main/src/com/google/android/ap
ps/dashclock/weather/WeatherExtension.java#267

and 269. 

I'd check in a fix if I wasn't at work :P

Original comment by ldjugg...@gmail.com on 12 Feb 2013 at 12:37

GoogleCodeExporter commented 9 years ago 
Oh, so the region is empty. That's pretty odd. Will see if there's other 
information I can use instead. Maybe "<Location>, <Country>" if region is 
missing.

Original comment by roman.nurik on 12 Feb 2013 at 1:20

GoogleCodeExporter commented 9 years ago 
Country seems right, I'm from the UK - most location look-ups don't provide a 
region/county here.

Original comment by ldjugg...@gmail.com on 12 Feb 2013 at 1:23

GoogleCodeExporter commented 9 years ago

Original comment by roman.nurik on 12 Feb 2013 at 9:09

GoogleCodeExporter commented 9 years ago 
This issue was closed by revision 27ca50ee16e9.

Original comment by roman.nurik on 13 Feb 2013 at 4:03

GoogleCodeExporter commented 9 years ago 
Will be fixed in version 1.1.

Original comment by roman.nurik on 13 Feb 2013 at 4:04

GoogleCodeExporter commented 9 years ago

Original comment by roman.nurik on 13 Feb 2013 at 4:07

GoogleCodeExporter commented 9 years ago

Original comment by roman.nurik on 17 Feb 2013 at 6:48