ronaldlokers / grunt-casperjs

Grunt task for casperjs
MIT License
104 stars 51 forks source link

If user has casperjs installed we make symlink to installed one #23

Closed soswow closed 11 years ago

soswow commented 11 years ago

I had casperjs installed with brew before I installed grunt-casperjs. So there is currently check for casperjs existence, but later in the code tries to run casperjs from the place where it was presumably downloaded to. So I create symlink in both cases (when I have own casperjs and when we download one)

TechNickAI commented 11 years ago

Nice work. Have you verified that the 3 scenarios (no casper, casper local, casper system) all work?

soswow commented 11 years ago

I tried without casper (uninstalled it with brew uninstall). It downloaded 1.0.3 and made symlink and it worked. Then I tried the same WITH casper installed and it made just a link pointing to my casper. Also I did everything one more time with casperjs 1.1-beta installed with brew - and casperjs task still works great. You can try it one more time just in case =)

On Fri, Aug 23, 2013 at 1:55 AM, Nick Sullivan notifications@github.comwrote:

Nice work. Have you verified that the 3 scenarios (no casper, casper local, casper system) all work?

— Reply to this email directly or view it on GitHubhttps://github.com/ronaldlokers/grunt-casperjs/pull/23#issuecomment-23132494 .