search

ronaldlokers / grunt-casperjs

Grunt task for casperjs
MIT License
104 stars 51 forks source link

Update casperjs version to 1.1-beta1. #26

Closed quentindemetz closed 11 years ago

quentindemetz commented 11 years ago

Make grunt-casperjs major.minor version numbers follow casperjs.

TechNickAI commented 11 years ago

Hey there @quentindemetz, since your pull request includes a change to package.json, it's conflicting with other releases we've done.

I am going to clean this code up a bit anyway - ie, this file is missing semi colons, and the version is listed twice, it should probably be a config variable at the top to be dry.

A question for you - is 1.1-beta1 safe to use? 1.0.3 is currently used because it is the latest "stable" version...

Secondly - did you know that as of release 1.0.7 of grunt-casperjs, we made it so that if you have your own casperjs installed, it uses that instead. So if you really need a new version, you are welcome to install casperjs yourself and it will use that if it finds it.

quentindemetz commented 11 years ago

I've been using 1.1-beta1 daily for about a month without issues. It works great!

I was aware of your second point but for some reason that didn't cut it... Don't quite remember why though.

Also, what do you think about making this package's major.minor follow casperjs' number scheme?

creynders commented 11 years ago

:-1: it's a really bad idea to sync your module's version to that of your main dependency, since the two aren't related except for the dependency obviously. How would you version changes to grunt-casperjs outside the release path of CasperJS?

quentindemetz commented 11 years ago

I was thinking about using the last version number for that - but I agree, it's not good it grunt-casperjs has some major changes one day. Nvm.

jatin commented 11 years ago

This issue is resolved by ronaldlokers/grunt-casperjs#30. Any locally installed version of casperjs can be used with grunt-casperjs.

cc @gorillamania