ronaldlokers / grunt-casperjs

Grunt task for casperjs
MIT License
104 stars 51 forks source link

Do not break other npm packages. #7

Closed paulmillr closed 11 years ago

paulmillr commented 11 years ago

Grunt-casperjs currently breaks other npm packages in some cases.

The simple line change fixes this.

chrisabrams commented 11 years ago

Thanks @paulmillr

ronaldlokers commented 11 years ago

I don't think this is a problem in my package, because the script I define in "main" really is the script it needs to run. Can you explain me why it should target the "tasks/casperjs.js"?

paulmillr commented 11 years ago

"main" script is something that will be required through npm, not loaded by grunt. when your package is required via npm, it throws an error because there is no grunt-casperjs/grunt.js file.

ronaldlokers commented 11 years ago

More coffee in the morning helps you read the documentation better ;-) I did take a look at the documentation again and I see that you are right about what should be in "main".

paulmillr commented 11 years ago

thanks!

chrisabrams commented 11 years ago

Thanks @paulmillr and @ronaldlokers !