ronaldombre / ReBrewie

Custom, Open-Source firmware for the Brewie B20+ (and maybe B20)
MIT License
11 stars 5 forks source link

Debug/Brewmaster fix cooling: Debug cooling enable now requires targe… #11

Closed ebuh closed 1 year ago

ebuh commented 1 year ago

Debug cooling (P128) now requires target temperature. This has been implemented in UI commit 1d7655ae.

This fixes the issue with debug/Brewmaster cooling on the recent ReBrewie firmware, as it now makes use of the same PID controller as heating. Instead of the current workaround by setting the heater to the cooling target temperature before enabling the cooling inlet, the cooling inlet button in UI 1d7655ae now triggers the numpad and appends a temperature to the P128 command.

Note that i haven't tested what would happen if P128 is being sent without the appended temperature, but this was broken already anyway.. :) Suggestion: it might be nice to set the temp to the lowest possible value (11c) in case P128 is received without a temperature in order to allow for some backwards compatibility.