ronaldossendrijver / treachery.online

treachery.online
10 stars 6 forks source link

When playing as Tielaxu, in revival stage other factions do not revive #16

Closed goodygoodygoody90 closed 4 months ago

goodygoodygoody90 commented 4 months ago

After I increase revival limits and progress to revival stage, factions do not complete revivals.

dune

ronaldossendrijver commented 4 months ago

Hi! Do you perhaps still have a savegame so i can analyse?

goodygoodygoody90 commented 4 months ago

Hi Ronald,

Thanks for looking into this. I've attached a saved file both just before and after the bidding phase.

Thanks, James


From: ronaldossendrijver @.> Sent: 01 April 2024 21:16 To: ronaldossendrijver/treachery.online @.> Cc: goodygoodygoody90 @.>; Author @.> Subject: Re: [ronaldossendrijver/treachery.online] When playing as Tielaxu, in revival stage other factions do not revive (Issue #16)

Hi! Do you perhaps still have a savegame so i can analyse?

— Reply to this email directly, view it on GitHubhttps://github.com/ronaldossendrijver/treachery.online/issues/16#issuecomment-2030570751, or unsubscribehttps://github.com/notifications/unsubscribe-auth/BHPEBNEGMVQXP3PUQW6KSM3Y3HFEHAVCNFSM6AAAAABFQK74P6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMZQGU3TANZVGE. You are receiving this because you authored the thread.Message ID: @.***>

ronaldossendrijver commented 4 months ago

I think I know what happened here. As you can see in the screenshot, Fremen did a request to be allowed to revive Stilgar, but you haven't denied or approved that request yet. All bots wait until all outstanding revival requests have been answered before reviving.

I think I can change this so that in a way that bots only wait until their own request has been answered.