ronaldoussoren / py2app

py2app is a Python setuptools command which will allow you to make standalone Mac OS X application bundles and plugins from Python scripts.
Other
340 stars 36 forks source link

the argument `know_paths` is missing in template for site.addsitedir #489

Closed typemytype closed 1 year ago

typemytype commented 1 year ago

the py2app template: https://github.com/ronaldoussoren/py2app/blob/master/src/py2app/apptemplate/lib/site.py#L70

the default python implementation for site.addsitedir and the source

Im receiving this error while pip installing inside an app:

Traceback (most recent call last):
        File "site.pyc", line 182, in <module>
        File "/private/tmp/pip-build-env-jsosmj26/site/sitecustomize.py", line 8, in <module>
          site.addsitedir(path, known_paths=known_paths)
      TypeError: addsitedir() got an unexpected keyword argument 'known_paths'

thanks!

colinmford commented 1 year ago

Thanks, @typemytype!

I'm also having the same issue — it seems to come up most when asking pip to install from a git repo, i.e. pip install git+https://github.com/joke2k/faker.git

typemytype commented 1 year ago

Closing this issue, as this is not an py2app issue, sorry for the fuzz