Missing test class for Gtin13

ronanguilloux / IsoCodes

PHP library - Validators for standards from ISO, International Finance, Public Administrations, GS1, Manufacturing Industry, Phone numbers & Zipcodes for many countries

GNU General Public License v3.0

792 stars 77 forks source link

Missing test class for Gtin13 #115

Closed soullivaneuh closed 7 years ago

soullivaneuh commented 7 years ago

But another Gtin validators have corresponding tests. Maybe a miss?

I also saw missing test for Dun14, Itf14 and Upca, but I'm suppose because they are deprecated. Am I right?

ronanguilloux commented 7 years ago

Ean13Test existed before Gtin13Test which is then an alias. We maintain Ean13 as it's still a widely used alt name for Gtin13. No need to duplicate tests.
Dun14, Itf14, and Upc-A are GTIN-* aliases