kps increased from 6000 to 14175

[Mudtjn]

There needed to be a condition, where if there is no start and end condition then the keypair is already a match. Also popping constantly from the keys array is a costly operation and using index to take keys.

[ronanyeah]

Thanks, having a look.

[ronanyeah]

• There won't be a situation where the return true; case is used.
• All the keys in the keys array need to be checked in the second promise, and I suspect the index iteration could miss some.

[Mudtjn]

I am unable to understand what it means about when will or else part of if(keypair) will hit. But have fixed increment conditions for the index.

[ronanyeah]

The keys array is a queue that will be filled by the first async loop, while the second async loop consumes the keys. Wouldn't there be a problem if the index = 5 and there are 3 elements in the array? They won't be checked. Using pop() prevents this.

[Mudtjn]

I was suggesting not to pop elements from keys array. I have used index to bypass the need to pop the elements from array. I won't be popping elements while using index.