ronatskiy / country-flags-svg

A list of countries with url links to a svg image which you can simply use in your web application
MIT License
29 stars 27 forks source link

fix: update broken links to some flags #57

Open a-kriya opened 8 months ago

a-kriya commented 8 months ago
a-kriya commented 6 months ago

I've been using a map with a helper to workaround the issue:

const fixedUrls = {
  BO: '/d/de/Flag_of_Bolivia_%28state%29.svg',
  CD: '/6/6f/Flag_of_the_Democratic_Republic_of_the_Congo.svg',
  IE: '/4/45/Flag_of_Ireland.svg',
  KG: '/3/31/Flag_of_Kyrgyzstan_%282023%29.svg',
  PS: '/0/00/Flag_of_Palestine.svg',
  RE: '/8/8e/Proposed_flag_of_Réunion_%28VAR%29.svg',
  ST: '/0/0a/Flag_of_São_Tomé_and_Príncipe.svg',
  VA: '/3/39/Flag_of_the_Vatican_City_%282023%E2%80%93present%29.svg',
}

function getFlagUrl(code) {
  if (Object.hasOwn(fixedUrls, code))
    return 'https://upload.wikimedia.org/wikipedia/commons' + fixedUrls[code]
  return findFlagUrlByIso2Code(code)  // from this package
}
AnisTigrini commented 4 months ago

Hi @a-kriya and @neriagini the developer seems to be away for some reason hope he is alright. I actually took the liberty to clone hist project and fix the issues that he had with typescript and the broken flag links. You can find the npm package right here https://www.npmjs.com/package/country-flags-svg-v2 hope this helps :)

samdemaeyer commented 2 months ago

Hi @ronatskiy .. will this PR be merged any time soon? Seems like a straightforward fix and it's been open for a while