rondale-sc / ember-cli-rails-addon

27 stars 37 forks source link

outputReady hook not firing #28

Open botandrose opened 8 years ago

botandrose commented 8 years ago

Heya heya, I'm getting an infinite loop in Ember-Cli-Rails when building the app, and I've tracked it down to the outputReady hook in this addon not firing. Don't have any hypotheses, at the moment. Here is the output log, if it helps.

Future versions of Ember CLI will not support v0.10.25. Please update to Node 0.12 or io.js.
version: 1.13.8
Could not find watchman, falling back to NodeWatcher for file system events.
Visit http://www.ember-cli.com/user-guide/#watchman for more info.
BuildingBuilding.Building..Building...BuildingBuilding...

Build successful - 1976ms.

Slowest Trees                                 | Total               
----------------------------------------------+---------------------
ES6: App Tree                                 | 530ms               
TemplateCompiler                              | 275ms               
TemplateCompiler                              | 244ms               
CoffeeScriptFilter                            | 240ms               

Slowest Trees (cumulative)                    | Total (avg)         
----------------------------------------------+---------------------
TemplateCompiler (3)                          | 537ms (179 ms)      
ES6: App Tree (1)                             | 530ms               
CoffeeScriptFilter (2)                        | 241ms (120 ms)      
rwjblue commented 8 years ago

You should try updating to the latest 1.13 version of ember-cli, I do not believe that 1.13.8 includes that hook.

This addon could detect ember-cli version and use the appropriate hook.

Robert Jackson

-- twitter: rwjblue -- github: rjackson

botandrose commented 8 years ago

Yes, thank you, @rwjblue, you are correct! Looks like outputReady was added in 1.13.12. Another possible solution could be changing this addon to depend on that version at minimum.

rwjblue commented 8 years ago

Yep, either work. But one or the other should be done.

For anyone willing to do the work, using ember-cli-version-checker and dep.isAbove('1.13.11') should do the trick...