search

rondale-sc / ember-cli-rails-addon

27 stars 37 forks source link

Warn if ember-cli-dependency-checker is missing. #4

Closed rwjblue closed 9 years ago

rwjblue commented 9 years ago

Addresses https://github.com/rwz/ember-cli-rails/issues/35.

rondale-sc commented 9 years ago

This has the desired affect when you run ember build (and similar ember-cli commands) but we aren't doing anything with the output from the system (or spawn) call in ember-cli-rails so this error message doesn't show up there.

We likely need to trap the string returned from system and show errors manually (or some similar mechanism).

/cc @rwz rwjblue https://github.com/rwz/ember-cli-rails/issues/35

rwjblue commented 9 years ago

@rondale-sc - Great point. Perhaps we could change this to write to stderr (via console.error), and in ember-cli-rails we pass through stderr?

rondale-sc commented 9 years ago

I'm not sure the mechanism. I believe stdout and stderr are shared with the parent process in spawn but ignored in system. We'll see what @rwz thinks. Either way, this is out.

https://www.npmjs.com/package/ember-cli-rails-addon

Bumped to 0.0.6 :)

Thanks for the PR :santa:

[edit] I'll try to check this in development, but it'll have to wait until later...travellin' and stuff

rondale-sc commented 9 years ago

Seems as if we are intentionally silencing the output from the system call here.

If you remove silence_stream the output from ember commands comes through in test, however, we lose all formatting which makes it looks a little cluttered. I don't think we can preserve the formatting, but maybe we can do something with that information.

Right now we get something that looks like this:

You can see the "Building..." stuff is just butted right up with the warning (which I was testing in this example).

Thoughts?