search

rondale-sc / ember-cli-rails-addon

27 stars 37 forks source link

Make jQuery support optional #40

Closed jnicklas closed 4 years ago

jnicklas commented 5 years ago

This is needed for this plugin to work with Ember Octane. This is a pretty minimal change which doesn't make CSRF work properly in Octane but simply ensures this doesn't blow up if jQuery isn't loaded. A more comprehensive change might be providing some kind of mixin for the adapter or something? I don't know Ember very well yet, so I'm not too sure on the best way to proceed here.

allthesignals commented 4 years ago

Hi! Can we merge? @rondale-sc @seanpdoyle

rwjblue commented 4 years ago

I think we need @seanpdoyle / @rondale-sc to release though...

joshkg commented 4 years ago

bump for release 🥺

straydogstudio commented 4 years ago

bump for release

sdhull commented 3 years ago

@seanpdoyle @rondale-sc release plz 🙏

camerondubas commented 2 years ago

Bump for release 🥺