search

rong-xiaoli / ArisuBot

爱丽丝bot，想要和sensei一起聊天
GNU Affero General Public License v3.0
0 stars 2 forks source link

Fixed logger. #38

Closed rong-xiaoli closed 3 days ago

rong-xiaoli commented 3 days ago

Fixed #37.

Summary by CodeRabbit

Release Notes

coderabbitai[bot] commented 3 days ago

[!IMPORTANT]

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

The pull request modifies multiple classes to replace the existing ElysiaLogger with MiraiLogger for logging purposes. This change is implemented across the Elysia, DailyFortune, DelayedDisposer, PicturesPlugin, and Ping classes. The updates involve removing static logger fields, adjusting logging method calls, and eliminating the use of a NAME constant in log messages. The overall control flow and functionality of the plugins remain unchanged, focusing solely on enhancing the logging framework used throughout the codebase.

Changes

File Change Summary
src/main/java/top/rongxiaoli/Elysia.java Removed static ElysiaLogger field; replaced with getLogger() method for logging in onEnable.
src/main/java/top/rongxiaoli/plugins/DailyFortune/DailyFortune.java Replaced ElysiaLogger with MiraiLogger; updated logging calls; removed NAME constant.
src/main/java/top/rongxiaoli/plugins/PicturesPlugin/DelayedDisposer.java Changed logger from ElysiaLogger to MiraiLogger; updated logging statements; added sleep in Shutdown.
src/main/java/top/rongxiaoli/plugins/PicturesPlugin/PicturesPlugin.java Updated to use MiraiLogger; removed NAME constant; adjusted logging calls.
src/main/java/top/rongxiaoli/plugins/Ping/Ping.java Transitioned from ElysiaLogger to MiraiLogger; simplified log messages; removed NAME constant.

Assessment against linked issues

Objective Addressed Explanation
Use MiraiLogger instead of ElysiaLogger (#37) ✅
Remove static logger initialization (#37) ✅
Simplify log messages by removing NAME constant (#37) ✅

Possibly related PRs

Suggested labels

code/features

Suggested reviewers

Poem

🐇 In the code where the loggers play,
A new friend, Mirai, came to stay.
Elysia's whispers fade away,
With clearer logs, we'll find our way.
So hop along, let errors sway,
In this bright code, we’ll leap and play! 🌟

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
🪧 Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://docs.coderabbit.ai) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
rong-xiaoli commented 3 days ago

@coderabbitai review

coderabbitai[bot] commented 3 days ago
:white_check_mark: Actions performed Review triggered. > Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.
rong-xiaoli commented 3 days ago

@coderabbitai review

coderabbitai[bot] commented 3 days ago
:white_check_mark: Actions performed Review triggered. > Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.