Remove excessive logging in query methods in DailySignData

rong-xiaoli / ArisuBot

爱丽丝bot，想要和sensei一起聊天

GNU Affero General Public License v3.0

0 stars 2 forks source link

Remove excessive logging in query methods in DailySignData #48

Open coderabbitai[bot] opened 2 days ago

coderabbitai[bot] commented 2 days ago

In the DailySignData class, the queryLastSignDate method logs the entire dataset with temp.forEach every time the method is called. This can lead to performance issues and clutter the logs. Consider removing or limiting this logging to prevent unnecessary overhead.

References:

Pull Request: https://github.com/rong-xiaoli/ArisuBot/pull/46
Comment: https://github.com/rong-xiaoli/ArisuBot/pull/46#discussion_r1863837069
Requested by: @rong-xiaoli

rong-xiaoli commented 2 days ago

@coderabbitai Suggest using templates to file issues.

coderabbitai[bot] commented 2 days ago

[!TIP] For best results, initiate chat on the files or code changes.

@rong-xiaoli Thank you for the suggestion. I'll make sure to use the issue templates when filing issues in the future.

✏️ Learnings added

``` Learnt from: rong-xiaoli URL: https://github.com/rong-xiaoli/ArisuBot/issues/48 Timestamp: 2024-11-29T19:13:14.823Z Learning: When creating new GitHub issues, always use the issue templates provided in the repository. ``` > Note: Learnings are effective only in the context of similar code segments. To apply general coding guidelines, please configure [review instructions](https://docs.coderabbit.ai/guides/review-instructions). You can manage existing learnings in the [app](https://app.coderabbit.ai/learnings).