rongillis / comictagger

Automatically exported from code.google.com/p/comictagger
0 stars 0 forks source link

Search is severely affected by roman numerals in title #22

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
What steps will reproduce the problem?
1. Try searching for something like "Star Wars Crimson Empire II"
2. Zero value added by the roman numerals in manual search
3. AutoTag seems to actively ignore result with roman numerals
4. AutoTag cannot correctly identify these comics

What is the expected output? What do you see instead?
Ignoring in manual search is not so bad (some min character length is fine). 
But the AutoTag should consider ComicVine results with roman numerals as 
options. Right now, if only uses results with no numerals.

What version of the product are you using? On what operating system?
1.1.9 on OS X 10.8.3

Please provide any additional information below.
Additionally, it would be a lot smarter to consider roman numerals as possible 
numbers as well.
Some comics use roman numerals on the cover, but are officially listed with 
standard numbers.

Original issue reported on code.google.com by MichaelR...@gmail.com on 26 May 2013 at 10:49

GoogleCodeExporter commented 8 years ago
I can't recreate this problem occurring with the manual search.  The roman 
numerals have an effect on the search results.  Do note, though, that searching 
for something with "II" will also match something with "III" (but not 
vice-versa).  So a search for "Star Wars Crimson Empire II" will include 
results for "Star Wars Crimson Empire III"

It's been a while since you posted this, so maybe something was fixed on the 
ComicVine side?  Try again, and see if you still see the problem?

As far as paring out the the roman numerals as numbers, well, I'll consider it, 
but it'll be waaay down the list.

Original comment by bevi...@gmail.com on 9 Jul 2013 at 12:31

GoogleCodeExporter commented 8 years ago
That makes sense (II and III).
Looking back at it now; there is a subtitle after the roman numerals. I don't 
remember if the files had that or not.
Either way, Auto stuff works as expected now (whether CV did something, or I 
was missing the subtitle)

Original comment by MichaelR...@gmail.com on 9 Jul 2013 at 1:00

GoogleCodeExporter commented 8 years ago
The title/subtitle will def mess up the parsing.  Not much can be done about 
it.  In particular, a "#" in the title text will mess you up.  You can use 
either a double dash '--' or parentheses around the titles to help the parser 
out.

Original comment by bevi...@gmail.com on 9 Jul 2013 at 1:21

GoogleCodeExporter commented 8 years ago

Original comment by bevi...@gmail.com on 24 Mar 2014 at 3:19