[Android Bootcamp] project 2 - Review my app

rongjiang commented 10 years ago

My app is complete. Pls review. One quick question: I've checked in all files in my project, do we need to do so or we should just check in the changed files going forward?

Unfortunately due to my tight schedule, I didn't have time to do the optional features. :-(

/cc @nesquena @thecodepath

vibhorB commented 10 years ago

Hi Ashley

I don't see all filters in the settings activity, type and size filters are missing. How soon can you complete this?

/cc @nesquena

nesquena commented 10 years ago

@rongjiang Ashley, please reply back here once you've completed the required user stories as soon as you can. I can give you a one-time 24 hour extension but if you'd like to continue with the bootcamp, please commit to submitting projects with required user stories complete by the deadline for the next 2 projects.

rongjiang commented 10 years ago

Just added the two search filters: type and size. Pls review.

rongjiang commented 10 years ago

I thought the user stories were complete when I submitted yesterday, thinking the 2 missing search filters won't affect the user stories as I had two already implemented - 2 instead of 4. Sorry for the misunderstanding.

vibhorB commented 10 years ago

Hi Ashley Thanks for fixing the code.Can you pls also add the updated GIF with two new filters?

Thanks Vibhor

rongjiang commented 10 years ago

I've updated github with my change and comments.

Thanks, Ashley

On Thu, Jun 19, 2014 at 12:34 AM, Nathan Esquenazi <notifications@github.com

wrote:

@rongjiang https://github.com/rongjiang Ashley, please reply back here once you've completed the required user stories as soon as you can. I can give you a one-time 24 hour extension but if you'd like to continue with the bootcamp, please commit to submitting projects with required user stories complete by the deadline for the next 2 projects.

— Reply to this email directly or view it on GitHub https://github.com/rongjiang/GridImageSearch/issues/1#issuecomment-46531661 .

rongjiang commented 10 years ago

gif also updated.

Thanks!

vibhorB commented 10 years ago

Nice work Ashley. A few notes after checking out the code:

Properly reused the single base method in search activity to fetch results for both initial load and the pagination
Properly used spinners (with populated values) to allow users to select filters
Good way of making QueryOption serializable so that you don't need to pass multiple keys
Consider better organizing your source files

Also, here's a more detailed Project 2 Feedback Guide here which covers the most common issues with this submitted project. Read through the feedback guide point-by-point to determine how you could improve your submission.

Let us know if you have any other thoughts or questions about this assignment. The next assignment (Twitter Client) will be especially important since it introduces the majority of the remaining pieces necessary to build a fully functional API client with complex feeds of data and user creation.

rongjiang commented 10 years ago

Thanks a lot for the review! I planned to go back to this project later to finish all the optional features. This week happened to be too hectic.

The projects are really interesting and it was a lot of fun doing it!

In future should we checkin all the code in project or just the files we created/modified?

Best, Ashley (from my iPhone)

On Jun 19, 2014, at 10:42 AM, vibhorB notifications@github.com wrote:

Nice work Ashley. A few notes after checking out the code:

Properly reused the single base method in search activity to fetch results for both initial load and the pagination Properly used spinners (with populated values) to allow users to select filters Good way of making QueryOption serializable so that you don't need to pass multiple keys Consider better organizing your source files Also, here's a more detailed Project 2 Feedback Guide here which covers the most common issues with this submitted project. Read through the feedback guide point-by-point to determine how you could improve your submission.

Let us know if you have any other thoughts or questions about this assignment. The next assignment (Twitter Client) will be especially important since it introduces the majority of the remaining pieces necessary to build a fully functional API client with complex feeds of data and user creation.

— Reply to this email directly or view it on GitHub.

vibhorB commented 10 years ago

Hi Ashley

Pls refer to submitting the assignment guide. You should setup .gitignore in future submissions which will avoid adding any generated files and eclipse environment files being checked-in. And in all subsequent check-ins you should just add the modified files. You can do so by following these steps -

git status - this will show which files have been modified
git add - do this for all modified files you want to checkin
git commit -m - commit changes locally
git push - push to remote repository

Hope this helps.

Thanks Vibhor

rongjiang commented 10 years ago

That's exactly what I did except that I missed the gitignore part. Thanks for the pointer!

Best, Ashley (from my iPhone)

On Jun 19, 2014, at 10:55 AM, vibhorB notifications@github.com wrote:

Hi Ashley

Pls refer to submitting the assignment guide. You should setup .gitignore in future submissions which will avoid adding any generated files and eclipse environment files being checked-in. And in all subsequent check-ins you should just add the modified files. You can do so by following these steps -

git status - this will show which files have been modified

git add - do this for all modified files you want to checkin

git commit -m - commit changes locally

git push - push to remote repository

Hope this helps.

Thanks Vibhor

— Reply to this email directly or view it on GitHub.

rongjiang / GridImageSearch

[Android Bootcamp] project 2 - Review my app #1