search

rongjiang / tip-calculator

0 stars 0 forks source link

[Android Bootcamp] project 1 - Review my app #1

Open rongjiang opened 10 years ago

rongjiang commented 10 years ago

My project (Tip Calculator) is complete. Pls review.

It was fun! Unfortunately I didn't have time to play with more icons/images this time. Other major functionalities are done.

Thanks!

/cc @nesquena @thecodepath

vibhorB commented 10 years ago

Nice work Ashley. A few notes after checking out the code:

One of the most important part of these projects is that you add additional features and tweak the UI / UX because that will provide many more learning opportunities. I would encourage you to push the projects each week, continue adding your own UI elements and experimenting with optional features that improve the user experience.

We have provided a detailed Project 1 Feedback Guide here which covers the most common points we see for this project. Read through the feedback guide point-by-point to determine other ways you could improve your submission. You should consider going back and implementing applicable feedback as well. Keep in mind that one of the most important parts of Android development is learning the correct patterns and conventions.

Hopefully this has given you a better sense of working with views and the RelativeLayout which is a very powerful layout system, probably one of the best responsive-first layout systems available across web and mobile platforms. The next assignment will build on top of the first concepts introduced here and will also introduce networking, api use, handling remote images and navigating between activities.

If you have any particular questions about the assignment in general or on any of the feedback, feel free to reply here or or email us support@thecodepath.com.

P.S. Good to see you properly added the readme with features and screenshots to your project as described in the submitting assignments guide!

rongjiang commented 10 years ago

Thanks a lot for the feedback! This is very helpful! The guide is also extremely useful.

Best, Ashley (from my iPhone)

On Jun 12, 2014, at 12:30 AM, vibhorB notifications@github.com wrote:

Nice work Ashley. A few notes after checking out the code:

Good to see you used addTextChangedListener for auto-updating on bill, tip and people Good use of margins, sp/dp in view Good use of different widgets for entering data(SeekBar) Good to see you changed EditText input type to launch numeric keypad only String constants should be inside strings.xml and not directly in view files. A better way would have been to re-use same method for calculating tips for all buttons instead of a separate method for each button. One of the most important part of these projects is that you add additional features and tweak the UI / UX because that will provide many more learning opportunities. I would encourage you to push the projects each week, continue adding your own UI elements and experimenting with optional features that improve the user experience.

We have provided a detailed Project 1 Feedback Guide here which covers the most common points we see for this project. Read through the feedback guide point-by-point to determine other ways you could improve your submission. You should consider going back and implementing applicable feedback as well. Keep in mind that one of the most important parts of Android development is learning the correct patterns and conventions.

Hopefully this has given you a better sense of working with views and the RelativeLayout which is a very powerful layout system, probably one of the best responsive-first layout systems available across web and mobile platforms. The next assignment will build on top of the first concepts introduced here and will also introduce networking, api use, handling remote images and navigating between activities.

If you have any particular questions about the assignment in general or on any of the feedback, feel free to reply here or or email us support@thecodepath.com.

P.S. Good to see you properly added the readme with features and screenshots to your project as described in the submitting assignments guide!

— Reply to this email directly or view it on GitHub.